Problem with duplicate books and books that contain only one chapter

tim-hub / obsidian-bible-reference

Take Bible Study notes easily in the popular note-taking app Obsidian, with automatic verse and reference suggestions.

https://antioch.tech/obsidian-bible-reference/

MIT License

226 stars 41 forks source link

Problem with duplicate books and books that contain only one chapter #66

Closed MarlusMM closed 11 months ago

MarlusMM commented 1 year ago

How I use duplicate books such as 1 and 2 Corinthians or 1 and 2 Kings and books that contain only one chapter, such as Jude? I Use Portuguese version - Almeida: João Ferreira de Almeida @tim-hub

JPT62089 commented 1 year ago

Just to add more context documented on the ticket after looking into this. It looks like when you type in --1cor1:1 as an example it will then search the Bible API with https://bible-api.com/1cor+1:1?translation=almeida. This will not work as the Bible API is expecting a space there. This is indeed a bug and not an issue on the end-user.

Bolls Life is not affected by this issue due to how it requires a book ID rather than a simple name query (e.g., "1 Corinthians 1:1" vs book id of 46).

Funny thing is this works just fine for other translations...

tim-hub commented 1 year ago

Just to add more context documented on the ticket after looking into this. It looks like when you type in --1cor1:1 as an example it will then search the Bible API with https://bible-api.com/1cor+1:1?translation=almeida. This will not work as the Bible API is expecting a space there. This is indeed a bug and not an issue on the end-user.

Bolls Life is not affected by this issue due to how it requires a book ID rather than a simple name query (e.g., "1 Corinthians 1:1" vs book id of 46).

Funny thing is this works just fine for other translations...

Thanks for investigation on this, @JPT62089

stale[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

dhyces commented 1 year ago

having an issue with this right now as well, will appreciate the fix when it's finished 👍

tim-hub commented 11 months ago

This should be fixed in the latest release.

For example: