Midi events uint offset

tim-janik / anklang

MIDI and Audio Synthesizer and Composer

https://anklang.testbit.eu/

Mozilla Public License 2.0

55 stars 4 forks source link

Midi events uint offset #43

Closed swesterfeld closed 9 months ago

swesterfeld commented 9 months ago

As discussed in #26, midi events should not contain negative frame offsets. Here is a PR for that.

I didn't change AUDIO_BLOCK_MAX_RENDER_SIZE as I'm not sure if that depends on anything else (and 2048 is certainly enough for all use cases I can think of), but in principle we now support frame offsets up to 4095.
micro-timing information provided by the alsa driver is discarded now, but we can look into this once we really implement recording

tim-janik commented 9 months ago

Thanks. Sadly the "Rebase and Merge" button of GH just rebases onto trunk, but does not add a dedicated merge commit, will have to push a separate "pr43/swesterfeld-midi-events-uint-offset" merge once the action run completed.