tim-janik / rapicorn

Rapicorn is a toolkit for declarative UI construction and SVG-based theming
https://rapicorn.testbit.org/
Mozilla Public License 2.0
12 stars 2 forks source link

No configure test for pandoc #11

Closed GvMariani closed 8 years ago

GvMariani commented 8 years ago

Rosa Linux ATM does not package pandoc, however rapicorn seems to need it:


It would be a good thing to test in configure for the presence of all the software needed to do a successful build...

tim-janik commented 8 years ago

Yes, we happily take patches ;-) Btw, I'd be happy to integrate RPM test builds into our travis setup (docker based) once you got working RPM build instructions for me.

GvMariani commented 8 years ago

I'm very little fond of the autotools intricacies, but is something as the snippet below enough?


dnl Check for pandoc AC_CHECK_PROG(HAVE_PANDOC, pandoc, true, false) if test "x$HAVE_PANDOC" = "xfalse"; then AC_MSG_ERROR([*\ Pandoc is needed by Rapicorn]) fi


GvMariani commented 8 years ago

Btw, I'd be happy to integrate RPM test builds into our travis setup (docker based) once you got working RPM build instructions for me.

I don't know much about docker and travis, but I guess you're already familiar with things as: https://docs.fedoraproject.org/en-US/Fedora_Draft_Documentation/0.1/html/RPM_Guide http://www.rpm.org/max-rpm If so, I can share and comment the .spec file I'm using to instruct the rpm build-system to do a rapicorn build: perhaps you can figure how to translate for your build setup...

GvMariani commented 8 years ago

I tested the snipped above with rapicorn 16.0.0 sources and it works: ie makes the configure pass to fail with a message when pandoc is not installed...

tim-janik commented 8 years ago

Commit a2b3a69c649f5c9008f8e8b74e6d70d615d1324e (and previous ones) properly check for pandoc now. Thanks for your input.