Closed rekado closed 8 years ago
Looks like some of the test output is missing. Not sure how you achieved that without modifying the test programs. On Debian and Ubuntu I don't get such errors: https://travis-ci.org/tim-janik/rapicorn/builds/121498013
Please provide instructions to reproduce the problem (the exact Rapicorn and OS versions are needed at the very least). Ideally, you provide a Dockerfile within which I can reproduce the build for your distribution.
Hey rekado, can you please give a quick rundown how to reproduce your problem? I.e. what distribution are you building on and what modifications did you apply to the sources?
@tim-janik I've packaged rapicorn for GNU Guix. The full recipe can be found here: http://git.savannah.gnu.org/cgit/guix.git/tree/gnu/packages/graphics.scm#n285
The only modification to the sources is patching references to /bin/ls
in the Makefile templates. Guix is a functional package manager, so it ignores any global mutable directories such as /bin/ls
.
In Guix the package is built in a chroot in which only declared inputs are available --- both explicitly declared inputs via the propagated-inputs
, native-inputs
, and inputs
fields, and implicit inputs pulled in by the build system (here gnu-build-system
).
Hey rekado,
please provide the full build log, the above error can happen if the test program generating the output failed. The exact error is then apparent from the build log preceeding the section you quoted. I.e. attach something like the ouput of: make check |& tee build.log in the failing directory.
It seems that this is a problem with our grep
--- it was compiled without Perl regexp support. Looks like the tests pass when I replace grep -P
with grep -E
.
Sorry for the false alarm!
On 15.05.2016 12:54, rekado wrote:
It seems that this is a problem with our |grep| --- it was compiled without Perl regexp support. Looks like the tests pass when I replace |grep -P| with |grep -E|.
Sorry for the false alarm!
Oh, is that in ./taptool.sh ? I think it's using grep -P because it uses "\s*" to match spaces. I'm not sure you can use grep -E to replace this, afaik '\s' isn't guaranteed to be supported by grep -E, or is it?
Yours sincerely, Tim Janik
https://testbit.eu/timj/ Free software author.
Tim Janik notifications@github.com writes:
On 15.05.2016 12:54, rekado wrote:
It seems that this is a problem with our |grep| --- it was compiled without Perl regexp support. Looks like the tests pass when I replace |grep -P| with |grep -E|.
Sorry for the false alarm!
Oh, is that in ./taptool.sh ? I think it's using grep -P because it uses "\s*" to match spaces. I'm not sure you can use grep -E to replace this, afaik '\s' isn't guaranteed to be supported by grep -E, or is it?
As far as I know, grep in both basic (-G) and extended regular expressions (-E) mode matches any number of spaces with “\s*”:
echo "helloworld" |grep -o -e "hello\s*world"
helloworld
echo "hello world" |grep -o -e "hello\s*world"
hello world
I’ve never used grep with Perl regex support; the manual says that “this is highly experimental and ‘grep -P’ may warn of unimplemented features.” Anyway, in this particular case it seems fine to use “-E”; the tests pass.
~~
I'm trying to package the latest release and find that one test is failing: