16.0.0: Test "testrcore1: match output: testrcore1.outref" fails

[rekado]

I'm trying to package the latest release and find that one test is failing:

  FAIL     testrcore1: match output: testrcore1.outref
--- testrcore1.outref   2016-03-18 00:20:03.774639898 +0000
+++ testrcore1.output   2016-04-11 17:53:29.070921754 +0000
@@ -11,145 +11,3 @@
 ::MyKey::destroy: delete 9;
 ### ---> DataList Tests [DONE] <--- ###

-
-### ---> IniFiles/Parsing [START] <--- ###
-  Section With Spaces And Comment.longvalue1="value contains line continuation"
-  Section With Spaces And Comment.longvalue2="value contains line continuation"
-  Section With Spaces And Comment.spacings=" \tspacing@start and spacing@end\f\t "
-  simple-section.key1="1"
-  simple-section.indented="value"
-  simple-section.empty=""
-  simple-section.colon="assignment"
-  simple-section.simple-key="simple-value"
-  simple-section.string-key="string with # Hash"
-  simple-section.name[de]="DE localized key"
-  simple-section.name["en_US.UTF-8"]="US localized key"
-### ---> IniFiles/Parsing [DONE] <--- ###
-
-
-### ---> Strings/CxxPrintf Output [START] <--- ###
-Char 'Y'                  right-adjusted: |                     Y|
-Char 'Y'                   left-adjusted: |Y                     |
-Char 'Y'     positional 0      truncated: |Y|
-decimal unsigned negative right-adjusted: |            3307312975|
-decimal signed-i negative right-adjusted: |            -987654321|
-decimal signed-d negative right-adjusted: |            -987654321|
-octal   unsigned negative right-adjusted: |           30510313517|
-hexadec unsigned negative right-adjusted: |              c521974f|
-Hexadec unsigned negative right-adjusted: |              C521974F|
-decimal unsigned negative  left-adjusted: |3307312975            |
-decimal signed-i negative  left-adjusted: |-987654321            |
-decimal signed-d negative  left-adjusted: |-987654321            |
-octal   unsigned negative  left-adjusted: |30510313517           |
-hexadec unsigned negative  left-adjusted: |c521974f              |
-Hexadec unsigned negative  left-adjusted: |C521974F              |
-decimal signed-i negative   space-padded: |            -987654321|
-decimal signed-d negative   space-padded: |            -987654321|
-decimal unsigned negative    zero-padded: |0000000000003307312975|
-decimal signed-i negative    zero-padded: |-000000000000987654321|
-decimal signed-d negative    zero-padded: |-000000000000987654321|
-octal   unsigned negative    zero-padded: |0000000000030510313517|
-hexadec unsigned negative    zero-padded: |00000000000000c521974f|
-Hexadec unsigned negative    zero-padded: |00000000000000C521974F|
-decimal unsigned positive right-adjusted: |             987654321|
-decimal signed-i positive right-adjusted: |             987654321|
-decimal signed-d positive right-adjusted: |             987654321|
-octal   unsigned positive right-adjusted: |            7267464261|
-hexadec unsigned positive right-adjusted: |              3ade68b1|
-Hexadec unsigned positive right-adjusted: |              3ADE68B1|
-decimal unsigned positive  left-adjusted: |987654321             |
-decimal signed-i positive  left-adjusted: |987654321             |
-decimal signed-d positive  left-adjusted: |987654321             |
-octal   unsigned positive  left-adjusted: |7267464261            |
-hexadec unsigned positive  left-adjusted: |3ade68b1              |
-Hexadec unsigned positive  left-adjusted: |3ADE68B1              |
-decimal signed-i positive   space-padded: |             987654321|
-decimal signed-d positive   space-padded: |             987654321|
-decimal unsigned positive    zero-padded: |0000000000000987654321|
-decimal signed-i positive    zero-padded: |0000000000000987654321|
-decimal signed-d positive    zero-padded: |0000000000000987654321|
-octal   unsigned positive    zero-padded: |0000000000007267464261|
-hexadec unsigned positive    zero-padded: |000000000000003ade68b1|
-Hexadec unsigned positive    zero-padded: |000000000000003ADE68B1|
-float   %f       positive right-adjusted: |              3.141593|
-float   %-f      positive  left-adjusted: |3.141593              |
-float   % f      positive   space-padded: |              3.141593|
-float   %0f      positive    zero-padded: |000000000000003.141593|
-float   %.0f     positive      truncated: |                     3|
-float   %#f      positive      alternate: |                    3.|
-float   %+f      positive    always-sign: |             +3.141593|
-float   %.5f     positive      precision: |              +3.14159|
-float   %F       positive right-adjusted: |              3.141593|
-float   %-F      positive  left-adjusted: |3.141593              |
-float   % F      positive   space-padded: |              3.141593|
-float   %0F      positive    zero-padded: |000000000000003.141593|
-float   %.0F     positive      truncated: |                     3|
-float   %#F      positive      alternate: |                    3.|
-float   %+F      positive    always-sign: |             +3.141593|
-float   %.5F     positive      precision: |              +3.14159|
-float   %e       positive right-adjusted: |          3.141593e+00|
-float   %-e      positive  left-adjusted: |3.141593e+00          |
-float   % e      positive   space-padded: |          3.141593e+00|
-float   %0e      positive    zero-padded: |00000000003.141593e+00|
-float   %.0e     positive      truncated: |                 3e+00|
-float   %#e      positive      alternate: |                3.e+00|
-float   %+e      positive    always-sign: |         +3.141593e+00|
-float   %.5e     positive      precision: |          +3.14159e+00|
-float   %E       positive right-adjusted: |          3.141593E+00|
-float   %-E      positive  left-adjusted: |3.141593E+00          |
-float   % E      positive   space-padded: |          3.141593E+00|
-float   %0E      positive    zero-padded: |00000000003.141593E+00|
-float   %.0E     positive      truncated: |                 3E+00|
-float   %#E      positive      alternate: |                3.E+00|
-float   %+E      positive    always-sign: |         +3.141593E+00|
-float   %.5E     positive      precision: |          +3.14159E+00|
-float   %g       positive right-adjusted: |                1e+100|
-float   %-g      positive  left-adjusted: |1e+100                |
-float   % g      positive   space-padded: |                1e+100|
-float   %0g      positive    zero-padded: |00000000000000001e+100|
-float   %.0g     positive      truncated: |                1e+100|
-float   %#g      positive      alternate: |               1.e+100|
-float   %+g      positive    always-sign: |               +1e+100|
-float   %.5g     positive      precision: |               +1e+100|
-float   %G       positive right-adjusted: |                1E+100|
-float   %-G      positive  left-adjusted: |1E+100                |
-float   % G      positive   space-padded: |                1E+100|
-float   %0G      positive    zero-padded: |00000000000000001E+100|
-float   %.0G     positive      truncated: |                1E+100|
-float   %#G      positive      alternate: |               1.E+100|
-float   %+G      positive    always-sign: |               +1E+100|
-float   %.5G     positive      precision: |               +1E+100|
-float   %a       positive right-adjusted: |0x1.249ad2594c37dp+332|
-float   %-a      positive  left-adjusted: |0x1.249ad2594c37dp+332|
-float   % a      positive   space-padded: | 0x1.249ad2594c37dp+332|
-float   %0a      positive    zero-padded: |0x1.249ad2594c37dp+332|
-float   %.0a     positive      truncated: |              0x1p+332|
-float   %#a      positive      alternate: |             0x1.p+332|
-float   %+a      positive    always-sign: |+0x1.249ad2594c37dp+332|
-float   %.5a     positive      precision: |       +0x1.249adp+332|
-float   %A       positive right-adjusted: |0X1.249AD2594C37DP+332|
-float   %-A      positive  left-adjusted: |0X1.249AD2594C37DP+332|
-float   % A      positive   space-padded: | 0X1.249AD2594C37DP+332|
-float   %0A      positive    zero-padded: |0X1.249AD2594C37DP+332|
-float   %.0A     positive      truncated: |              0X1P+332|
-float   %#A      positive      alternate: |             0X1.P+332|
-float   %+A      positive    always-sign: |+0X1.249AD2594C37DP+332|
-float   %.5A     positive      precision: |       +0X1.249ADP+332|
-String  'char-string'     right-adjusted: |           char-string|
-String  'char-string'      left-adjusted: |char-string           |
-String   0x0                null pointer: |                (null)|
-char       : -107 107 k k
-short      : -107 107
-int        : -107 107
-long       : -107 107
-long long  : -107 107
-float      : 3.141593 3.14159 3.141593e+00 0x1.921fb6p+1
-double     : 3.141593 3.14159 3.141593e+00 0x1.921fb54442d18p+1
-long double: 3.141593 3.14159 3.141593e+00 0xc.90fdaa22168cp-2
-min long long: 8000000000000000 1000000000000000000000 9223372036854775808 -9223372036854775808 -9223372036854775808
-max long long: ffffffffffffffff 1777777777777777777777 18446744073709551615 -1 -1
-positionals-reorder: |3 2 1|
-positionals-repeat:  |3.141593 == 3.141593|
-positionals-widths:  |  abc|
-### ---> Strings/CxxPrintf Output [DONE] <--- ###
-
  ERROR    testrcore1: broken tests encountered: 1
Trace/breakpoint trap
  ERROR    testrcore1: non-zero exit status: 133
Makefile:963: recipe for target 'testrcore1.taprun' failed
make[4]: *** [testrcore1.taprun] Error 133
make[4]: *** Waiting for unfinished jobs....

[tim-janik]

Looks like some of the test output is missing. Not sure how you achieved that without modifying the test programs. On Debian and Ubuntu I don't get such errors: https://travis-ci.org/tim-janik/rapicorn/builds/121498013

Please provide instructions to reproduce the problem (the exact Rapicorn and OS versions are needed at the very least). Ideally, you provide a Dockerfile within which I can reproduce the build for your distribution.

[tim-janik]

Hey rekado, can you please give a quick rundown how to reproduce your problem? I.e. what distribution are you building on and what modifications did you apply to the sources?

[rekado]

@tim-janik I've packaged rapicorn for GNU Guix. The full recipe can be found here: http://git.savannah.gnu.org/cgit/guix.git/tree/gnu/packages/graphics.scm#n285

The only modification to the sources is patching references to /bin/ls in the Makefile templates. Guix is a functional package manager, so it ignores any global mutable directories such as /bin/ls.

In Guix the package is built in a chroot in which only declared inputs are available --- both explicitly declared inputs via the propagated-inputs, native-inputs, and inputs fields, and implicit inputs pulled in by the build system (here gnu-build-system).

[tim-janik]

Hey rekado,

please provide the full build log, the above error can happen if the test program generating the output failed. The exact error is then apparent from the build log preceeding the section you quoted. I.e. attach something like the ouput of: make check |& tee build.log in the failing directory.

[rekado]

It seems that this is a problem with our grep --- it was compiled without Perl regexp support. Looks like the tests pass when I replace grep -P with grep -E.

Sorry for the false alarm!

[tim-janik]

On 15.05.2016 12:54, rekado wrote:

It seems that this is a problem with our |grep| --- it was compiled without Perl regexp support. Looks like the tests pass when I replace |grep -P| with |grep -E|.

Sorry for the false alarm!

Oh, is that in ./taptool.sh ? I think it's using grep -P because it uses "\s*" to match spaces. I'm not sure you can use grep -E to replace this, afaik '\s' isn't guaranteed to be supported by grep -E, or is it?

Yours sincerely, Tim Janik

https://testbit.eu/timj/ Free software author.

[rekado]

Tim Janik notifications@github.com writes:

On 15.05.2016 12:54, rekado wrote:

It seems that this is a problem with our |grep| --- it was compiled without Perl regexp support. Looks like the tests pass when I replace |grep -P| with |grep -E|.

Sorry for the false alarm!

Oh, is that in ./taptool.sh ? I think it's using grep -P because it uses "\s*" to match spaces. I'm not sure you can use grep -E to replace this, afaik '\s' isn't guaranteed to be supported by grep -E, or is it?

As far as I know, grep in both basic (-G) and extended regular expressions (-E) mode matches any number of spaces with “\s*”:

echo "helloworld" |grep -o -e "hello\s*world"
helloworld

echo "hello   world" |grep -o -e "hello\s*world"
hello   world

I’ve never used grep with Perl regex support; the manual says that “this is highly experimental and ‘grep -P’ may warn of unimplemented features.” Anyway, in this particular case it seems fine to use “-E”; the tests pass.

~~