search

tim-koehler / Helm-Intellisense

Extension for Visual Studio Code - Intellisense in helm-templates from the values.yaml
https://marketplace.visualstudio.com/items?itemName=Tim-Koehler.helm-intellisense&ssr=false#overview
MIT License
1.6k stars 23 forks source link

lint on save not working and autocomplete bug #42

Closed NazarovNikita closed 2 years ago

NazarovNikita commented 2 years ago

Hi, @tim-koehler lint does not work when saving (no info in output), but if you run the helm intellisense: lint chart command, everything works. Also auto-completion does not work if helm-intellisense.customValueFileNames are specified

vscode:

Version: 1.60.2 (Universal) Commit: 7f6ab5485bbc008386c4386d08766667e155244e Date: 2021-09-22T11:59:27.195Z (2 wks ago) Electron: 13.1.8 Chrome: 91.0.4472.164 Node.js: 14.16.0 V8: 9.1.269.39-electron.0 OS: Darwin arm64 20.6.0

macbook: MacBook Pro (13-inch, M1, 2020) macos: 11.6 (20G165)

PS: thanks for the great extension - best for DevOps

marcfrederick commented 2 years ago

I assume this is related to the handling of missing value files in the helm-intellisense.customValueFileNames array. If one of the files in this array can not be opened, an error is thrown causing the auto-completion to fail. This is caused by the merge-yaml package attempting to open files without previously checking whether they exist. 

[2021-10-16 23:02:49.552] [exthost] [error] Error: ENOENT: no such file or directory, open '/Users/marcfrederick/src/my-test-chart/missing.yaml'
    at Object.openSync (fs.js:476:3)
    at Object.func [as openSync] (electron/js2c/asar_bundle.js:5:1846)
    at Object.readFileSync (fs.js:377:35)
    at Object.readFileSync (electron/js2c/asar_bundle.js:5:8872)
    at /Users/marcfrederick/src/Helm-Intellisense/node_modules/merge-yaml/index.js:12:47
    at Array.forEach (<anonymous>)
    at merge (/Users/marcfrederick/src/Helm-Intellisense/node_modules/merge-yaml/index.js:11:16)
    at Object.loadMerge (/Users/marcfrederick/src/Helm-Intellisense/out/yaml.js:23:12)
    at Object.getValuesFromFile (/Users/marcfrederick/src/Helm-Intellisense/out/utils.js:54:17)
    at ValuesCompletionItemProvider.provideCompletionItems (/Users/marcfrederick/src/Helm-Intellisense/out/CompletionProviders/ValuesCompletionItemProvider.js:24:31)
    at U.provideCompletionItems (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:94:180724)
    at /Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:94:200950
    at xe._withAdapter (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:94:191024)
    at xe.$provideCompletionItems (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:94:200926)
    at i._doInvokeHandler (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:98:13802)
    at i._invokeHandler (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:98:13486)
    at i._receiveRequest (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:98:12097)
    at i._receiveOneMessage (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:98:10826)
    at /Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:98:8922
    at a.fire (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:66:1712)
    at l.fire (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:74:15990)
    at /Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:113:30514
    at a.fire (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:66:1712)
    at l.fire (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:74:15990)
    at u._receiveMessage (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:74:21260)
    at /Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:74:18138
    at a.fire (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:66:1712)
    at v.acceptChunk (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:74:13351)
    at /Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:74:12699
    at Socket.w (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:113:13465)
    at Socket.emit (events.js:315:20)
    at addChunk (internal/streams/readable.js:309:12)
    at readableAddChunk (internal/streams/readable.js:284:9)
    at Socket.push (internal/streams/readable.js:223:10)
    at Pipe.onStreamRead (internal/stream_base_commons.js:188:23)
    at Pipe.callbackTrampoline (internal/async_hooks.js:131:14)

I'll create a patch and create a pull request as soon as its ready.