search

tim-koehler / Helm-Intellisense

Extension for Visual Studio Code - Intellisense in helm-templates from the values.yaml
https://marketplace.visualstudio.com/items?itemName=Tim-Koehler.helm-intellisense&ssr=false#overview
MIT License
1.67k stars 25 forks source link

Syntax checking should ignore comments #54

Closed KagurazakaNyaa closed 2 years ago

KagurazakaNyaa commented 2 years ago

https://github.com/prometheus-community/helm-charts/blob/5c6f26588c0815d53cbc2ec68e8626b7bef69a41/charts/kube-prometheus-stack/values.yaml#L210 will report "Template not defined"

https://github.com/prometheus-community/helm-charts/blob/5c6f26588c0815d53cbc2ec68e8626b7bef69a41/charts/kube-prometheus-stack/values.yaml#L2512 will report "Value not defined"

But these codes start with #, indicating that they are a comment and should not be checked for syntax.

tim-koehler commented 2 years ago

Hey @KagurazakaNyaa Thanks for reporting that bug. values.yaml should not be linted at all! This is fixed now.