search

tim-kos / node-retry

Abstraction for exponential and custom retry strategies for failed operations.
Other
1.22k stars 80 forks source link

Add Typescript support #49

Closed itsJess1ca closed 2 years ago

itsJess1ca commented 7 years ago

I believe I covered the majority of the API but this should be a good start in providing typescript support

huan commented 6 years ago

:+1:

tim-kos commented 6 years ago

There is one conflict. Once fixed, I am happy to merge this.

itsJess1ca commented 6 years ago

That should cover that, haven't checked here in a while, sorry about that.

tim-kos commented 6 years ago

Hm GitHub still reports a conflicted package.json. Did you merge master from upstream?

itsJess1ca commented 6 years ago

My bad - wasn't paying much attention last time :P All good now.

sshine commented 3 years ago

@tim-kos: Considering the age of this PR, what do you think is the shortest path to getting something similar for latest master? Could I submit a separate PR with another attempt, and would you be willing to tag your repo with 'hacktoberfest' before I do? :-D

sshine commented 3 years ago

In fact, I realize, this PR should not be necessary considering https://www.npmjs.com/package/@types/retry

tim-kos commented 2 years ago

Closing then in favor of the ts definitions here https://www.npmjs.com/package/@types/retry