tim-kos / node-retry

Abstraction for exponential and custom retry strategies for failed operations.
Other
1.22k stars 80 forks source link

Stop retry timer with operation.stop() #69

Closed danielfdsilva closed 4 years ago

danielfdsilva commented 5 years ago

Fix tim-kos/node-retry/#64

codecov[bot] commented 5 years ago

Codecov Report

Merging #69 into master will increase coverage by 0.2%. The diff coverage is 80%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master      #69     +/-   ##
=========================================
+ Coverage    90.2%   90.41%   +0.2%     
=========================================
  Files           2        2             
  Lines         143      146      +3     
=========================================
+ Hits          129      132      +3     
  Misses         14       14
Impacted Files Coverage Δ
lib/retry_operation.js 86.45% <80%> (+0.43%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 88548b9...0326585. Read the comment docs.

danielfdsilva commented 4 years ago

@harking Anything else needed to have this merged?

tim-kos commented 4 years ago

Alll good! Thank you!