search

tim-we / tabs-aside

A session/tab manager web extension for Firefox based on the Microsoft Edge feature.
https://addons.mozilla.org/firefox/addon/tabs-aside/
GNU General Public License v3.0
89 stars 10 forks source link

some minor issues with 3.3.0 #74

Closed ootada closed 4 years ago

ootada commented 4 years ago

  1. window titles seem to be not being set on Firefox restart

  2. with "Do not set aside pinned tabs" unchecked (I want to save my pinned tabs) and a window containing "about:" (or similar tabs that can't be set aside):

    • clicking "tabs aside" / "save tabs as session" reopens all 'saveable' tabs (including pinned) in a new window which is registered as a session window (and closed afterwards for "tabs aside")
    • !! pinned tabs are left unclosed in the old window along with unsaveable tabs, which gives 2 windows with same pinned tabs when "save tabs as session" as a result (should be fixed)
    • with windows of some 100+ tabs all of this commotion with new window popping, tabs moving, some not, some in 2 places feels somewhat confusing (and might be an area for improvement), but seems not to lose any tabs in the end (which is a basic expectation :)

  3. I would suggest changing the option "Do not set aside pinned tabs" to "Set aside pinned tabs" as negative options are somewhat confusing in general.

thank you.

tim-we commented 4 years ago

I found the cause of this and I am working on a fix. I will release a patched version on AMO as soon as possible.

tim-we commented 4 years ago

The fixed version 3.3.1 is now live on AMO. Thanks for submitting this bug! I think changing "Do not set aside pinned tabs" to "Set aside pinned tabs" is a good idea so I will keep this issue open until that is done.

ootada commented 4 years ago

(1) is still an issue with v3.3.3, window title prefix is lost on firefox restart

tim-we commented 4 years ago

Oh I forgot about that one, sorry. I think this is a bug with Firefox, since the window title is a property of a window and Firefox does not restore that part. Perhaps we should open an issue on bugzilla... However even if they accept that as a bug it would take ages for the fix to be shipped so I will fix it. Probably in the next couple days...

tim-we commented 4 years ago

As of version 3.3.4 the title prefix should be restored. The new version is available.

tim-we commented 4 years ago

I would suggest changing the option "Do not set aside pinned tabs" to "Set aside pinned tabs" as negative options are somewhat confusing in general.

Done! Will be part of the next release.