tim95030 / androminion

Automatically exported from code.google.com/p/androminion
0 stars 0 forks source link

Possession / Hermit #469

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Play possession
2. Play Hermit from possessed player's hand
3. Don't buy anything

What is the expected output? What do you see instead?
I should be prompted to trash Hermit for Madmen, but it doesn't seem to be 
reaching the prompt.

Please use labels and text to provide additional information.

Original issue reported on code.google.com by tkden...@gmail.com on 23 Oct 2012 at 2:37

GoogleCodeExporter commented 9 years ago
This issue was closed by revision r692.

Original comment by tkden...@gmail.com on 23 Oct 2012 at 3:40

GoogleCodeExporter commented 9 years ago
Looks like the possessed player doesn't actually trash the card you choose with 
Hermit.  I (the player who played Possession) do correctly get to make the 
choice now, so at least that part works.

Not sure if you want this here or in a separate issue.

Original comment by August.D...@gmail.com on 23 Oct 2012 at 3:45

GoogleCodeExporter commented 9 years ago
Doesn't the possessed player get to keep all the cards trashed during the 
possession, regardless when they get trashed? 

Original comment by tkden...@gmail.com on 23 Oct 2012 at 4:12

GoogleCodeExporter commented 9 years ago
tl,dr version: Yes, the possessed player gets to keep their cards, but they 
still get trashed.

Possession reads (in part): "[A]ny cards of [the possessed player] that are 
trashed are set aside and returned to his discard pile at end of turn."  So, 
when a card is trashed it goes to a "fake trash", not the actual trash.  That 
means, among other things, they cannot be retrieved with Graverobber.  However, 
the card is still considered "trashed", so two things should happen.

1) The card should be removed from the player's hand/discard and put into the 
fake trash.
2) Any "when <x> is trashed" abilities should trigger.  (Overgrown Estate, 
Rats, Market Square, etc>)

On the possessed players turn, the second thing doesn't happen.  Also, I don't 
think cards trashed from the discard pile with Hermit stay in the discard pile 
instead of going to the fake trash, but I can't remember for sure whether I 
tested that.

Original comment by August.D...@gmail.com on 25 Oct 2012 at 8:45

GoogleCodeExporter commented 9 years ago
tl,dr: Can you test again with r697 (or later)?  

Scenario 1:
1. I possess Earl who is holding Hermit and Market Square
2. Make him play Hermit
3. Trash a Colony from his discard pile
4. Market Square discard option is activated
5. Discard Market Square to gain a gold
6. Finish the Hermit by gaining a silver
Play area: Hermit
Earl's discard pile: Market Square
Possession Gained pile: gold, silver
Trash pile: empty
Fake Trash: Colony

Make Earl do cleanup
7. No buy, so I make Earl trash the Hermit for a Madman
Earl's discard pile: Market Square
Possession Gained pile: gold, silver, Madman
Trash pile: empty
Fake Trash: Colony, Hermit

Earl's turn ends
Earl's discard pile: Hermit, Market Square, Colony
My discard pile: gold, silver, Madman
Trash pile: empty
Fake Trash: empty

I tested without a trashable card at #3, and was able to activate the Market 
Square after #7 for the same result. I also ran a test with a WatchTower in my 
hand to send my 3 cards gained to the top of my deck. 
*** All of this was done in the VDOM core so I don't know if the UI is 
refreshing properly or if IndirectPlayer has issues until I can get the same 
card combos during game play. 

Original comment by tkden...@gmail.com on 26 Oct 2012 at 2:50

GoogleCodeExporter commented 9 years ago
Your scenario works in the app too.  I feel like there's still some weird stuff 
going on, but this stuff is a huge pain to test, so I'm going to leave it alone 
for now.  I'll open new issues for new stuff.

Original comment by August.D...@gmail.com on 29 Oct 2012 at 8:51