Several changes... - Githubissues

timabell / ef-enum-to-lookup

Generates lookup tables from enum references in Microsoft Entity Framework 6.1

https://www.nuget.org/packages/ef-enum-to-lookup

69 stars 29 forks source link

Several changes... #51

Closed jnhaffey closed 8 years ago

jnhaffey commented 8 years ago

Added Custom Schema on Enum Tables; Added support for custom schema with EF Code First Models; Added Constructor with configuration param; Cleaned up / Refactored a lot of code;

Was unable to make your unit tests and examples work, missing something on my side. I did build it, drop it into my project and test it and all seems to work.

timabell commented 8 years ago

thanks, I'll take a proper look when I have time

timabell commented 8 years ago

the .vs is not intended to be shared and shouldn't be checked in
this commit does too many things in one go, I'd like to see one commit for each step of the change, eg a commit for each cleanup / refactor followed by commits making the actual changes; I wouldn't accept this in its current form

jnhaffey commented 8 years ago

Right, not sure why the .vs was checked in, it is in my .gitIgnore so sorry about that. I'll try to revamp the check-ins when I get some time. Like you, I do not have a lot of time.