Added option to change type of Name field to varchar, to reduce size of enum tables

Hi Tim I’ve added this PR, because:

nvarchar is using twice the size as varchar
It is good practice to use proper data type and in our case we are sure we won’t need nvarchar
There is also performance aspect, if row has bigger size then it will take slightly more time to read it and process. We are going to use it in our reporting application with lots of rows, so it might have some impact.

I hope that this PR will merge with master branch at some point 😊 Anyway thank you for your work on this package.

Best regards Łukasz Cokot

From: Tim Abell notifications@github.com Sent: 06 September 2019 10:28 To: timabell/ef-enum-to-lookup ef-enum-to-lookup@noreply.github.com Cc: Lukasz Cokot Lukasz.Cokot@thebegroup.co.uk; Author author@noreply.github.com Subject: Re: [timabell/ef-enum-to-lookup] Added option to change type of Name field to varchar, to reduce size of enum tables (#67)

Cheers for the PR. I wouldn't be inclined to merge this currently because:

It increases the code complexity
I'm not clear on the practical benefit
Everything should be utf-8 now anyway

I'd be interested to know why you would want to reduce the storage size. Enums are usually pretty insignificant amounts of data in a normal database.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/timabell/ef-enum-to-lookup/pull/67?email_source=notifications&email_token=ANAMSSURMWIRBATDOPODTRLQIIPBBA5CNFSM4IUGIJH2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6CJOWQ#issuecomment-528783194, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ANAMSSQTLMKYBGQEIOTAW3LQIIPBBANCNFSM4IUGIJHQ.

Lukasz Cokot IT Developer

E-Mail: Lukasz.Cokot@thebegroup.co.uk

[The Be Group]

Be Group Holdings (UK) Limited and subsidiary companies are registered in England and Wales. Registered number: 04347049. Registered Office: Technology Business Park, Moy Avenue, Eastbourne, BN22 8LD.

This e-mail from Lukasz Cokot a member of the Be Group Holdings (UK) Limited group of companies (Be Group) and any attachments may be confidential or legally privileged. If you have received this message in error or are not the intended recipient, you should destroy the e-mail message and any attachments or copies, and you are prohibited from retaining, distributing, disclosing or using any information contained herein. Please note that Be Group does not accept responsibility for viruses and it is your responsibility to scan attachments (if any).

timabell / ef-enum-to-lookup

Added option to change type of Name field to varchar, to reduce size of enum tables #67