search

timabell / ssrs-powershell-deploy

PowerShell scripts to deploy a SQL Server Reporting Services project (*.rptproj) to a Reporting Server
MIT License
75 stars 40 forks source link

Replaces Write-Host with Write-Verbose #19

Closed ahmedig closed 7 years ago

ahmedig commented 7 years ago

Write-Host is harmful, and also not supported in VSTS automation tasks.

timabell commented 7 years ago

Are you okay with this being under the newly added MIT license? Also just for my info do you have a reference as to why it's bad so I can learn more? Thanks

ahmedig commented 7 years ago

Hey @timabell ,

Write-Host doesn't work in VSTS build pipeline as you know. It was breaking for me until I replaced it with Write-Verbose. Also have a look at this please: http://www.jsnover.com/blog/2013/12/07/write-host-considered-harmful/

Thanks

timabell commented 7 years ago

Cheers, and are you okay with the new license?

ahmedig commented 7 years ago

Can you please be more clear? What's special about the license?

Sent from my iPhone

On 8 Mar 2017, at 8:23 am, Tim Abell notifications@github.com wrote:

Cheers, and are you okay with the new license?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

timabell commented 7 years ago

Sure. The licence has only just been added to the project, so I want to make sure you are okay with this change before including your PR in the project.

ahmedig commented 7 years ago

Yeah sure am ok

Sent from my iPhone

On 8 Mar 2017, at 8:23 am, Tim Abell notifications@github.com wrote:

Cheers, and are you okay with the new license?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.