search

timaeus-research / devinterp

Tools for studying developmental interpretability in neural networks.
71 stars 14 forks source link

Better progress bars on sampler in single-threaded runs #67

Closed JasonGross closed 2 months ago

JasonGross commented 7 months ago

Good call, updated

svwingerden commented 7 months ago

Request to change from tqdm import tqdm to import tqdm.auto as tqdm, otherwise it doesn't work for notebooks. Also, this doesn't work when running with cores >1 passed to sample: terminal image notebook image

JasonGross commented 7 months ago

Request to change from tqdm import tqdm to import tqdm.auto as tqdm, otherwise it doesn't work for notebooks.

Do you mean from tqdm.auto import tqdm? I've done this (though note that there was already a use of tqdm without auto before this PR)

Also, this doesn't work when running with cores >1 passed to sample:

Hrm, I've tried passing leave=True in the hopes that this might fix it, but I don't have time to test it right now. (Also, I suspect the previous version that was already using tqdm was not very multicore friendly.) It also might be the case that from tqdm.auto import tqdm might be enough to fix the problem, since it seems that this might import a more async-friendly tqdm.