search

timanovsky / subdir-heroku-buildpack

Allows to use subdirectory configured via environment variable as a project root
https://medium.com/@timanovsky/heroku-buildpack-to-support-deployment-from-subdirectory-e743c2c838dd
523 stars 327 forks source link

Don't delete the build directory root #10

Closed edmorley closed 3 years ago

edmorley commented 3 years ago

Since otherwise once Heroku builds are run from /app, builds will output warnings due to the /app root being read only:

remote: -----> Subdir buildpack app detected
...
remote:        cleaning build dir /app
remote: rm: cannot remove '/app': Read-only file system

Fixes #9.

edmorley commented 3 years ago

@timanovsky Hi! Sorry to ping you directly, but this buildpack is one of the most popular of the sub directory/monorepo style buildpacks on Heroku, so it would be great to get this merged to prevent user confusion once the build directory changes. Many thanks :-)

timanovsky commented 3 years ago

Thanks @edmorley for providing the patch. I have not been maintaining this code for some time.

edmorley commented 3 years ago

@timanovsky Thank you for merging :-)

timanovsky commented 3 years ago

Thank you for the patch :)

On Thu, 1 Apr 2021 at 16:00, Ed Morley @.***> wrote:

@timanovsky https://github.com/timanovsky Thank you for merging :-)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/timanovsky/subdir-heroku-buildpack/pull/10#issuecomment-811890048, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJLIFSEMSXFEEIHTP3WU3TTGRU6BANCNFSM4YMPOSAA .

-- Best regards, Alexey Timanovsky.