search

timanovsky / subdir-heroku-buildpack

Allows to use subdirectory configured via environment variable as a project root
https://medium.com/@timanovsky/heroku-buildpack-to-support-deployment-from-subdirectory-e743c2c838dd
523 stars 327 forks source link

Build is not aborted if an error occurs #8

Open edmorley opened 3 years ago

edmorley commented 3 years ago

If an error occurs during the compile of this buildpack, the build continues on regardless rather than failing, since the bash error on exit mode is not enabled.

For improved reliability, it would be great to add a set -e, or even better, set -euo pipefail.

See also: http://redsymbol.net/articles/unofficial-bash-strict-mode/

Many thanks :-)