search

timarney / react-app-rewired

Override create-react-app webpack configs without ejecting
MIT License
9.79k stars 425 forks source link

anyone using rewire with webpack 5? #550

Closed louischristopherchen closed 2 years ago

louischristopherchen commented 3 years ago

I just want to start my new project with webpack 5 and rewire. I have checked the issue for CR4, and they said it's work perfectly. I want to make sure it's work fine with webpack 5.

TimRChen commented 2 years ago

image

TimRChen commented 2 years ago

react-app-rewired current no active. I recommand to use craco. https://github.com/gsoft-inc/craco/issues/313

ImanMh commented 2 years ago

@TimRChen CRACO has the same issue. It does not work with CRA@5

dawnmist commented 2 years ago

I believe the original issue was that the version number for react-scripts at the time had the -next.37 ending, and hence the version number wasn't being parsed from the version string. Now that react-scripts 5 has actually been released this should not continue to be an issue and react-app-rewired should work.

Note also: this is npm itself failing to parse the react-scripts package version as satisfying the requirement for being >= 2.1.3, not something that react-app-rewired itself is failing. There isn't much we can do if npm's version parsing is broken when there is a suffix. Hence also why it affects other packages like CRACO - it's not the individual packages that have the problem, it's the package manager itself.

timarney commented 2 years ago

Closing this - can re-open if it does turn out to be a bug with this repo.