search

timarney / react-app-rewired

Override create-react-app webpack configs without ejecting
MIT License
9.77k stars 425 forks source link

fix(dep): added peer dep to babel-jest to avoid errors #588

Closed emish89 closed 2 years ago

emish89 commented 2 years ago

Added babel jest as a peer dep , version lower than 27 because if not it will throw errors (for example with CRA5)

timarney commented 2 years ago

If @dawnmist or others can confirm this is needed --- happy to merge.

I haven't used Create React App or react-app-rewired for a number of years now so relying on others to let me know if this breaks or maintains things.

dawnmist commented 2 years ago

I think I'd like to see the outcome from #589, as it looks like it may be a better solution than tying react-app-rewired to an older version of babel-jest than what people would normally need to have installed with react-scripts.

timarney commented 2 years ago

Going to close this and we can re-open as needed.