Closed bencergazda closed 2 years ago
Thanks @bencergazda --- I think I'll spin up a "next" release for this for testing prior to a real release.
@dawnmist outside of ensuring this is backwards compatible any other thoughts?
Just published under "next tag" if anyone can test & confirm.
Some 3rd party packages (like @storybook/preset-create-react-app) require these files, serving as a base for their own configuration.
marged.
@bencergazda does this feel like a feature release to you or a patch
@timarney I'd rather say this is a feature!
Published 2.2.0
Thanks for the PRs
@timarney Sorry, but after the first install, I realized that we need to add /config
to the files
array in package.json. Otherwise npm publish
strips that folder from the package. This problem didn't show up while installing the git repo. 😞
This doesn't affect the core functionality, but the mocked config folder won't be accessible until we fix this. Submitted #606 with the correction.
react-scripts
has aconfig
folder that contains the base webpack or devServer configuration. Some 3rd party packages (like@storybook/preset-create-react-app
) require these files, serving as a base for their own configuration.This PR:
config/webpack.config.js
,config/webpackDevServer.config.js
andconfig/paths.config.js
files that export the rewired configuration EVEN if we didn't call thereact-app-rewired
command.This makes storybook (and probably many other packages) plug and play also for the rewired apps.