fix: Premature removal of the --config-overrides CLI argument

[bencergazda]

Cannot start test script if the config-overrides path is set via command-line argument, because it gets removed before the final paths config is done.

Steps to reproduce:

• call the test script like this: react-app-rewired test --config-overrides path-to-a-config-overrides.js

The test should not start, even with a correct path, because the config-overrides argument gets stripped out from the process.argv array during initialization, and tries to load the config-overrides.js from its default location (the project root).

The issue doesn't occur

• if we have a config-overrides.js in the project root
• or if we set the config-overrides-path in the project's package.json

This hotfix uses the same pattern as we have for removing the --scripts-version argument.

[yifanwww]

I also faced this problem but in build script, I guess start script will also fail.

Here I just make a description about why this problem happens.

After the release of v2.1.10, paths.js will be required two times, and the --config-overrides path will get deleted when we require this file (see line 22).

Before spawning a new process to execute build, start or test, bin/index.js will require paths.js (via dependRequire.js). So when it start to spawn a new process, the variable nodeArgs passed to the new process no longer contains the --config-overrides argument.

And that's why this MR can fix it, the line 22 is deleted.

[bencergazda]

@yifanwww This is definitely true, thanks for the clarification.

[lidaof]

I am also having this issue I removed line 22 seems make the --config-overrides argument to work again... this seems not merged...any other fix? otherwise need to modify the file on every machine i guess?

[yifanwww]

@lidaof Don't know when this pr can be merged... you can use version 2.1.9 if you don't need the new features or bug fixes in v2.1.10 and v2.1.11

[lidaof]

Thank you @yifanwww for reply. Looks like 2.1.9 still has this line in the file?

[yifanwww]

@lidaof Yes it has. But the file dependRequire.js doesn't exist, so paths.js is only required once and only after spawning the new process. So --config-overrides still exists when we need it.

[lidaof]

That's great to know, thank you so much! @yifanwww

[timarney]

I'll likely merge #593 on the weekend and this one as well

After that I'll publish the next version

https://github.com/timarney/react-app-rewired/pull/593#issuecomment-1022078672

cc: @dawnmist

[timarney]

I'll get this merged + pushed up tonight.

[timarney]

Conflicts need to be fixed first

[bencergazda]

@timarney I am going to submit an updated version in a few hours.

[bencergazda]

@timarney Now it is ready to merge