search

timber / debug-bar-timber

Debug Bar Extension for the Timber Library
https://github.com/timber/debug-bar-timber
56 stars 8 forks source link

Entire Debug Bar not showing on Frontend #23

Closed landwire closed 4 years ago

landwire commented 4 years ago

Hi there, I have the latest version of Wordpress, debug bar and timber debug bar installed. The debug bar shows fine in the backend, with the timber option. But in the frontend of the site, the debug bar is not showing at all if I have timber debug bar installed. I have Timber 1.18.1 installed.

In my debug.log are no errors thrown afaics.

Anybody has similar problems?

landwire commented 4 years ago

Ok, it's in the html. Looks like a CSS styling issue. I have a look.

landwire commented 4 years ago

Ok, the problem comes from this rule from timber-debug-bar.scss

wpadminbar .ab-top-secondary {

top: -33px;

}

manzwebdesigns commented 4 years ago

First, thanks for using the toolbar! We appreciate it. I will fix that and get a new version up today.

manzwebdesigns commented 4 years ago

PR merged and new version released. Thanks for that!

jarednova commented 4 years ago

Excellent, thanks @landwire and @manzwebdesigns for the info and the quick fix!!!

landwire commented 4 years ago

You are welcome. Is there still the old version on wpackagist? When I download over wordpress, I can see the changes. But via composer after deleting etc. the CSS was still there.

Maybe it helps to bump the version to 1.0.6 also on the wordpress repo and not just here?

jarednova commented 4 years ago

@landwire hmmmm, strange. The upload script we have to wp.org is supposed to keep that in sync as well. @manzwebdesigns could you take a look at that?

manzwebdesigns commented 4 years ago

Yeah, I will look at it later today.

blendjasper commented 4 years ago

@manzwebdesigns Could you have a look? https://wordpress.org/plugins/debug-bar-timber/ lists version 1.0.5

manzwebdesigns commented 4 years ago

Hi @blendjasper, I am not sure what is going on. I just created a new release, 1.0.7, and pushed it to the WP plugins but it still reflects 1.0.5 there.

jasperkooij commented 4 years ago
Screen Shot 2020-10-28 at 20 58 47

@manzwebdesigns I've deleted and reinstalled the plugin and it is back on the admin bar. It is the right code but listed as "Version 1.0.5".

Does https://github.com/timber/debug-bar-timber/blob/master/debug-bar-timber.php need a version number update?

manzwebdesigns commented 4 years ago

Wow, what a n00b mistake! It now reflects the correct version. Thank you for catching that and for your patience!

jasperkooij commented 4 years ago

@manzwebdesigns Glad, I could help. I use this toolbar all the time!

manzwebdesigns commented 4 years ago

@jasperkooij Thanks for using it. Please feel free to contact me if you would like to see new features added. We are very interested in building this out to be as useful as possible!