search

timber / docs

Static site documentation for Timber
https://timber.github.io/docs/
2 stars 9 forks source link

Title should be "Extending Twig" #67

Closed drdogbot7 closed 2 years ago

drdogbot7 commented 2 years ago

Issue

The page is titled "Extending Timber", which is already a separate page. This page is more precisely about extending Twig.

Solution

Change the title to "Extending Twig"

Impact

This will make the documentation less confusing, and will have no negative side effects.

gchtr commented 2 years ago

This issue was already resolved in https://github.com/timber/timber/pull/2602. And I updated the documentation just now, so the new title should be there: https://timber.github.io/docs/v2/guides/extending-twig/.

Pull requests to the documentation should be done against the timber/timber repository, because the timber/docs repository pulls in the documentation content from that repository. Maybe we can make that clearer.

But thanks a lot for taking the time to make a pull request for a documentation issue!