search

timber / starter-theme

The "_s" for Timber: a dead-simple theme that you can build anything from
MIT License
812 stars 274 forks source link

Comment input box is shown twice #101

Closed flip111 closed 3 years ago

flip111 commented 4 years ago

One include

https://github.com/timber/starter-theme/blob/cc8e530a9cd5ece12467dd1a95e1bf47e4b618a8/templates/single.twig#L34

Above that comments.twig is included

https://github.com/timber/starter-theme/blob/cc8e530a9cd5ece12467dd1a95e1bf47e4b618a8/templates/single.twig#L25

Which renders another comment box

https://github.com/timber/starter-theme/blob/41c74ff9d68ff36fce4e1561e9cd98ddda1c6286/templates/comment.twig#L8

flip111 commented 4 years ago

Maybe i did not understood this correctly. And comments itself can be commented to. Though i don't see variables passed down to the form so how to distinguish .. i think it's still an incomplete example. Better leave out things if they don't fully work

marciojc commented 3 years ago

Each form has a hidden input (comment_parent) with a comment.ID or 0. That way we can distinguer them.

flip111 commented 3 years ago

Thanks for your explanation