Move "WordPress files" to a subdirectory

szepeviktor commented 4 years ago

Closes #102

@jarednova :)

szepeviktor commented 4 years ago

Nice outlook :)

kép

szepeviktor commented 4 years ago

That "template" and "templates" bothers me. Please advise.

gchtr commented 4 years ago

It’s funny that somebody asked how to do this just yesterday on Stack Overflow.

I would propose a structure like this.

.
└── wp-content/themes/starter-theme/
    ├── bin/
    ├── src/
    │   └── StarterSite.php
    ├── static/
    ├── tests/
    ├── theme/
    │   ├── archive.php
    │   ├── author.php
    │   ├── footer.php
    │   ├── functions.php
    │   ├── header.php
    │   ├── index.php
    │   ├── page.php
    │   ├── search.php
    │   ├── single.php
    │   ├── screenshot.png
    │   └── style.css
    ├── views/
    ├── .gitignore
    ├── .travis.yml
    ├── LICENSE
    ├── composer.json
    ├── humans.txt
    ├── phpunit.xml
    └── README.md

(Edit here%5Cn20.562%20%203theme4source!5php62%01654320*))

I’d call the template subfolder theme, because that folder would contain all the files that are typical to a WordPress theme. But I guess templates would work too.
As proposed by @szepeviktor in https://github.com/timber/getting-started-theme/issues/1#issuecomment-647980870, classes could be placed in the src folder and not in functions.php. Autoloading could be handled with Composer.
As @davidhund proposed in https://github.com/timber/starter-theme/issues/102#issuecomment-639315529, we could rename the folder that contains the Twig files from templates to views and use the term "template" for WordPress/PHP template files. We also often use the term "view" throughout the documentation. Yes it’s called "Twig template engine", but it’s also called "[WordPress Template Hierarchy](WordPress Template Hierarchy)".

szepeviktor commented 4 years ago

It’s funny that somebody asked how to do this just yesterday on Stack Overflow.

Is he a clone of me?? 🙄

szepeviktor commented 4 years ago

I would propose a structure like this.

I agree with theme/ and views/

szepeviktor commented 4 years ago

Thank you for the fix.

szepeviktor commented 4 years ago

@jarednova Could you give me a proper English sentence to add to What's here? section of the README?

timber / starter-theme

Move "WordPress files" to a subdirectory #103