timber / starter-theme

The "_s" for Timber: a dead-simple theme that you can build anything from
MIT License
818 stars 278 forks source link

Advice to install timber. #123

Closed flip111 closed 3 years ago

flip111 commented 3 years ago

As i understood development on the 1. branch has slowed down and the main focus is now on 2.. Since i'm starting a fresh theme i will go with the 2. branch. Which advices me to install the plugin with composer directly into the theme. See https://github.com/timber/timber/tree/2.x#installation Which i also like because it gives me a bit more control and i'm not that big of a wordpress fan ironically. For starting the theme i also take the 2. branch of the starter theme. My question is if i can still use composer to install timber, or should i follow the instructions in the theme https://github.com/timber/timber/tree/2.x#installation to use the wordpress plugin instead?

szepeviktor commented 3 years ago

AFAIK Timber v2 contains features not allowed on WP.org.

Please see

https://github.com/timber/starter-theme/blob/2f8e086475964f9846a546aad2000401cd956656/composer.json#L20

which will later be "timber/timber": "^2.0"

szepeviktor commented 3 years ago

Please consider pressing ENTER while writing your comment to please readers :)

flip111 commented 3 years ago

Thank you @szepeviktor .. i conclude from your answer the readme has to be updated with this information and i can go ahead and use composer.