search

timber / starter-theme

The "_s" for Timber: a dead-simple theme that you can build anything from
MIT License
818 stars 278 forks source link

2.x Revert theme subfolder #139

Closed gchtr closed 1 year ago

gchtr commented 1 year ago

In #103, all template files were moved into a subfolder for a better file structure. However, this leads to consequences like wrong paths for images (see https://github.com/timber/timber/issues/2453).

We could fix these issues and work around it, but is it worth it? I don’t think the benefit of having a nicer file structure is bigger than having to manage various issues, because the file structure doesn’t follow the WordPress standard.

If people still wanted to use that structure, we could add filters in the appropriate places in Timber core that would allow them to fix these issues themselves. But we probably shouldn’t handle this case in Timber core itself.

This pull request reverts the changes in #103 and moves the theme files back to the root folder.

szepeviktor commented 1 year ago

Oh nooo! I've even developed a solution for non-Composer installation (ZIP upload). https://github.com/szepeviktor/wordpress-website-lifecycle/blob/master/mu-plugins/_core-theme-subdir.php