search

timber / starter-theme

The "_s" for Timber: a dead-simple theme that you can build anything from
MIT License
818 stars 278 forks source link

feat: rework of PHP files. #152

Closed Levdbas closed 4 months ago

Levdbas commented 5 months ago

This is the first changes in a larger set of changes that I am going to propose.

Related:

Issue

Since the creation of the starter theme a lot has happened in PHP, WordPress and Timber. I want to make the starter-theme a more modern starting point for custom theme development.

Solution

This particular PR focusses on overhauling the PHP files to:

Impact

A better, less confusing, start with templating in Timber.

Usage Changes

Code is now namespaced, so people will have to add filters/actions with a namespace reference as well. In a next PR I will also solely focus on the starttheme class.

Considerations

This is not adhering to any code style yet, I would like to introduce that soon as well and thus lint the whole codebase.

Testing

I might try to add some overall tests in the upcoming few PR's

Levdbas commented 4 months ago

@gchtr , I went over all your requests. As mentioned, I would like to discuss how the starter theme should look like but all other items are done!

gchtr commented 4 months ago

@Levdbas Thanks for the updates! This looks good to me.

Hit me up with anything you want to discuss :):