timber / starter-theme

The "_s" for Timber: a dead-simple theme that you can build anything from
MIT License
817 stars 276 forks source link

register_taxonomies before register_post_types #43

Closed danburzo closed 7 years ago

danburzo commented 7 years ago

A small detail, but it's often the case that custom post types will supoort a custom taxonomy, so it's useful to have the call to register_taxonomies before register_post_types.

danburzo commented 7 years ago

Or is it the case that people normally use register_taxonomy_for_object_type() inside register_taxonomies?

jarednova commented 7 years ago

@danburzo — can you submit a PR with current best practices? I'd love to get that up-to-date

danburzo commented 7 years ago

Sorry, seems the problem was in a different part of my code, and actually the registration order does not seem to matter 🤔