search

timberland-sig / dracut

dracut the event driven initramfs infrastructure
https://github.com/dracutdevs/dracut/wiki
GNU General Public License v2.0
0 stars 0 forks source link

fix(nvmf): test if "nvme connect-all --nbft" is supported #8

Closed mwilck closed 1 year ago

mwilck commented 1 year ago

... and simplify the "timeout" logic.

We can't blindly assume that "nvme connect-all --nbft" is supported; while the support for this option has been merged upstream, it hasn't been released in any official nvme-cli version.

In the timeout case, we can just run "nvme connect-all" now, simplifying the code for the initqueu case, where we apply the previously defined priorities.

@johnmeneghini, this is the part of #7 that got lost when you updated it from to 9865102 and merged it into #6.

If you disagree with this code, please provide a reason.

johnmeneghini commented 1 year ago

We can't blindly assume that "nvme connect-all --nbft" is supported; while the support for this option has been merged upstream, it hasn't been released in any official nvme-cli version.

In the timeout case, we can just run "nvme connect-all" now, simplifying the code for the initqueu case, where we apply the previously defined priorities.

@johnmeneghini, this is the part of #7 that got lost when you updated it from to [9865102]( and merged it into #6.

I don't know how that happened. Sorry about this.

If you disagree with this code, please provide a reason.

No disagreement at all thanks for fixing this.