search

timberline-secondary / hackerspace-scripts-2

Python based control panel and scripts for managing Timberline's Digital Hackerspace
GNU General Public License v3.0
3 stars 1 forks source link

Add media: gif conversion to vid are too inconsistant #115

Closed tylerecouture closed 1 year ago

tylerecouture commented 1 year ago

Example: https://d10ge8y4vx8iud.cloudfront.net/public_media/portfolios/video/2022/10/for_when_something_goes_wrong.gif

It was supposed to cycle the gif 4 times per issue #47 but that's too short for really fast gifs like this one. Also, currently script doesn't cycle at all anyway.

Should loop for 5 seconds, or one full cycle, whichever is shorter.

Also, the current process of converting gif to mpv doesn't seem to work properly (or maybe it's a lack of looping?)

Here's the result of above coverted: https://user-images.githubusercontent.com/10604391/204057937-7562db7f-dfad-45b5-825c-c0a182eb9a38.mp4

punctuations commented 1 year ago

The current script only loops per amount of frames, in this case, one full cycle of the gif is only two frames (on and off) and so that's all that the video output will last for as well, I can implement a minimum time or minimum number of frames, but I need to know what these values should be

tylerecouture commented 1 year ago

See the original issue, it had code for how to do it. I assumed since you closed the issue that this was already completed. I notice that it also doesn't ask: https://github.com/timberline-secondary/hackerspace-scripts-2/issues/47