timberline-secondary / hackerspace-scripts-2

Python based control panel and scripts for managing Timberline's Digital Hackerspace
GNU General Public License v3.0
3 stars 1 forks source link

Gif to mp4 videos break player #128

Closed tylerecouture closed 1 year ago

tylerecouture commented 1 year ago

Whatever is being output from the gif to video script is breaking the video player. Does it use ffmpeg or something else?

Here's an example that breaks the video player when converted to mp4: https://d10ge8y4vx8iud.cloudfront.net/public_media/portfolios/video/2022/11/sunset.gif

Test using the underlying video player, omxplayer locally before PRing your fix. Or to debug, you can view logs on a pi-tv:

image

punctuations commented 1 year ago

It seems the example you linked is ~2 frames long, therefore it would have to be using ffmpeg specifically this: 02dd8e6 (#121) (the command given here: https://github.com/timberline-secondary/hackerspace-scripts-2/issues/47#issue-1289288838)

tylerecouture commented 1 year ago

Ok. Well we know the pictures to mp4 videos work, can you look to see if there is any difference? Do they both use the same encoding etc? The gif to vid command is using yuv240p, I think that's different?

punctuations commented 1 year ago

What's the picture to mp4 video stuff? I didn't even know that was something that happened

tylerecouture commented 1 year ago

The slideshow generator. Refresh video? It takes all the uploaded picture media (PNG and jpg) and generates an MP4 from them

On Mon, Dec 5, 2022, 22:48 Matt @.***> wrote:

What's the picture to mp4 video stuff?

— Reply to this email directly, view it on GitHub https://github.com/timberline-secondary/hackerspace-scripts-2/issues/128#issuecomment-1338867338, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACQ46Z6XQXXNZBVLR4FA7GLWL3OTBANCNFSM6AAAAAASUZQ4GE . You are receiving this because you authored the thread.Message ID: @.*** com>

punctuations commented 1 year ago

I've ran the converted gif on the raspberry pi TV, however that does not seem to be an issue with it, it displays fine. Here is a screenshot of the crashed log of tv3:

image
tylerecouture commented 1 year ago

Ok, I'll leave it to you if you want to try to troubleshoot that, or generate the gif>mp4 using a different process.

punctuations commented 1 year ago

for a progress update, it has been almost solved, I am using moviepy to make the gif conversion better; however, on short gifs (I assume <1s [i.e. <~5 frames]) they stutter in the middle for some reason where it freezes on just 1 frame for a little bit