Provide full path in opam-selection.nix instead of filename

timbertson / opam2nix

Generate nix expressions from opam packages

MIT License

93 stars 28 forks source link

Provide full path in opam-selection.nix instead of filename #62

Closed ZabelTech closed 2 years ago

ZabelTech commented 2 years ago

Hi, I compiled https://github.com/mirage/mirage-skeleton with opam2nix. Because of that project layout it would be convenient to have opam2nix pickup the full path to the opam file, as given via the resolve command. This patch is doing exactly this.

Disclaimer: First time user here. I don't know whether this change has any implications on other use cases.

timbertson commented 2 years ago

Hi 👋

Generally, I want to use relative paths because that way it's more likely you can commit the generated file into git and have it work for others. You say it would be more convenient to have absolute paths, so can I ask what's the problem / difficulty that this fixes?

timbertson commented 2 years ago

(feel free to reopen with a follow-up)