timbertson / opam2nix

Generate nix expressions from opam packages
MIT License
93 stars 28 forks source link

Make use of pin-depends #69

Open rgrinberg opened 2 years ago

rgrinberg commented 2 years ago

Opam has [this field] to allow users to set the archive url for a package in development. It would be nice to make use of it when generating the opam selection.

timbertson commented 2 years ago

I haven't used this feature, so I'm not too familiar.

pin-depends: are NOT transitive, that is, pin-depends: of packages getting pinned through pin-depends: are ignored

So it sound like it's only supposed to apply to the toplevel package? And should it apply when the package is coming from the repo, or only when it's an out-of-repo opam file?

rgrinberg commented 2 years ago

So it sound like it's only supposed to apply to the toplevel package?

Yes, although I'm skeptical of this limitation. I would not mind if it's not implemented.

And should it apply when the package is coming from the repo, or only when it's an out-of-repo opam file?

The latter. Although it doesn't matter much in practice as opam-repository contains no packages with pin-depends set.