Some tweaks for better package support

timbertson / opam2nix

Generate nix expressions from opam packages

MIT License

93 stars 28 forks source link

Some tweaks for better package support #9

Closed bobot closed 6 years ago

bobot commented 6 years ago

This MR adds some tweaks for better support of packages:

consider that the depext for nixpkgs is a path so that we can use gnome2.sourceview (eg. conf-gtksourceview)
set the preinstalled variable so that package consider they can't be installed in the ocaml directory (usually they then use ocamlfind) (eg. num with OCaml >= 4.06 ).

My repository of opam-repository contains updated version of the packages for opam2nix. I'm going to ask for merge after at least the first point is accepted here.

timbertson commented 6 years ago

consider that the depext for nixpkgs is a path so that we can use gnome2.sourceview (eg. conf-gtksourceview)

Yay :tada:

My repository of opam-repository contains updated version of the packages for opam2nix. I'm going to ask for merge after at least the first point is accepted here.

What to you mean by updated? There's a weekly travis job that runs and pulls in opam-repository master, is that sufficient?

bobot commented 6 years ago

What to you mean by updated? There's a weekly travis job that runs and pulls in opam-repository master, is that sufficient?

Yes, it is. You put together a great workflow. My updated version is just adding some depext or other tweaks for nix. They will be taken by your travis job as soon as I have created the pull request and it is accepted.

Why do you use numVersion = "2.3.2"? For my use case, CI testing with ocaml versions from 4.02.3 to 4.07, I'm using null because the first version is sometimes needed. For example ocamlbuild.0 is the only one available for ocaml 4.02.3 since back then OCamlbuild was integrated to OCaml.

timbertson commented 6 years ago

Why do you use numVersion = "2.3.2"?

Practical reasons, I've had to rebuild the package set a number of times and my internet is embarrassingly slow. I don't really like the thought of an infinitely growing package set either, but I guess it should never get that unweildy since opam itself has to deal with the full set. Now that the digests get cached, it shouldn't actually require a mass-download very often.

I was hoping this would be enough to cover most uses, but maybe not. Perhaps once the opam2 stuff is done I'll give * a go and just wait it out.

bobot commented 6 years ago

It took me 20 minutes to get all the set. The updated cache is in my repository.

timbertson commented 6 years ago

20 minutes? The current set took me the better part of a day :man_facepalming: . Thanks!