timbertson / shellshape

tiling window manager extension for gnome-shell
http://gfxmonk.net/shellshape/
Other
396 stars 38 forks source link

Shellshape captures 'p' key. #172

Open rvlander opened 8 years ago

rvlander commented 8 years ago

Updating from ubuntu 15.10 to 16.04 (gnome 3.18), 'p' key is captured by gnome-shell and it happens only when shellshape is activated.

This is very inconvenient since 'p' can't be typed anymore in applications.

I tried reinstalling shellshape, resetting shortcuts, and I also tried the git version. The issue appears in all cases.

None of the shellshape shortcut is set to 'p'.

timbertson commented 8 years ago

That's... pretty bad :(

I'm not sure what the cause could be. The default shortcut to tile changed from win+p to win+o before gnome 3.16 support, so that shouldn't be the cause.

I can't reproduce (if I could I'd hopefully have fixed this by now). If you're able, I'd suggest running the git version, and commenting out all of the handle(...) lines in https://github.com/timbertson/shellshape/blob/816fdb114678b4ab66bf100a58623e5af9e7fbda/src/gjs/extension.ts#L349 (make sure to make compile after each change). If that fixes it, gradually uncomment lines / batches until you narrow down the exact shortcut which is causing the problem.

Alternatively, there may be something weird in your stored dconf settings (have you ever customised shellshape's shortcuts?). I don't know how to purge these though, I'm afraid.

rvlander commented 8 years ago

Offending line is line 369: handle('set-layout-fullscreen', function() { self.change_layout(Tiling.FullScreenLayout); });

The shortcut setting in dconf for set-layout-fulscreen is ['<Mod4><Shift>f']

timbertson commented 8 years ago

Sorry for the delay in getting back on this. Have you tried binding this to something else? I'm afraid I don't know what else to try or what the probblem might be. Since shellshape is just telling gnome APIs about these keyboard bindings rather than actually handling any input itself, I think the bug must be somewhere in gnome (not a very specific place to look, I know). I do know that win+p is special and weird in gnome (https://bugzilla.gnome.org/show_bug.cgi?id=651571), but I don't know if that's related to the bug you're seeing.

NoraCodes commented 8 years ago

I have this problem as well, even after changing the keybinding.

rvlander commented 8 years ago

@SilverWingedSeraph, I had to comment this line directly into the code.

duffolonious commented 8 years ago

FWIW, I also had the problem and it confused me to no end (why when I go to a vt does it work?).

uuencode commented 7 years ago

I had the same problem, Ubuntu Gnome 16.04 clean install - removed all key bindings with dconf-editor and I am ok now.

dseynaev commented 7 years ago

+1 same issue, Ubuntu 16.04. Modifying the set-layout-fullscreen key binding in dconf did not help. I may be noteworthy that the p key works fine until I reload the gnome shell (<alt>+f2 r). So as a workaround I currently disable shellshape, reload gnome and enable shellshape again.

rvlander commented 7 years ago

Installing this extension from the source and commenting the offending line works like a charm (as explained above).

tejaskale commented 7 years ago

This is still a Problem. I installed shellshaPe a few days ago and my 'P' stoPPed working today. Frustrating.

dongcarl commented 7 years ago

Please fix this, this issue makes the package unusable.

djwf commented 7 years ago

I do not know if this helps, but the p key is not unusable everywhere: it works in the system search, but not in terminator, firefox, or chrome. What information would be needed to fix this problem?

ctcoulter commented 7 years ago

also having this problem

dongcarl commented 7 years ago

@timbertson Is there a timeline for a fix? Anything we can do to help? A little bit concerned that an issue that renders a user's system unusable doesn't have a timeline for a fix on a project that's marked as "maintained."

timbertson commented 7 years ago

If this were definitely a bug in shellshape I'd be trying to fix it, but as I've said previously I have very little to go on. There's no reason to suspect the bug is in shellshape - it just uses the gnome shell APIs for binding keys, and it's definitely not grabbing the p key.

This only appears to be an issue on ubuntu, so my guess is it's something buggy in gnome-shell or a related system library which is either caused by or only triggered in ubuntu. I don't have an installation of ubuntu handy, nor do I have any idea how to track down such a bug - I've tried tracking down bugs in mutter in the past, and it's not an easy job. If anyone else is willing to find out which library the bug is actually in and file an upstream issue somewhere that'd be great, but that's not something I'm planning to do myself any time soon.

tejaskale commented 7 years ago

For someone completely uninitiated in gnome-shell development, What to look at when the next time this bug shows up? Is there a gnome-shell error console or something similar?

timbertson commented 7 years ago

I wish I could answer that - I definitely wouldn't expect it to be in logs anywhere, my best guess is that it's a bug somewhere in gnome shell, one of its libraries (most likely), or the window system. Unfortunately that's a lot of surface area :/