Wrong usage of Bidirectional GRU

timbmg / Sentence-VAE

PyTorch Re-Implementation of "Generating Sentences from a Continuous Space" by Bowman et al 2015 https://arxiv.org/abs/1511.06349

580 stars 152 forks source link

Wrong usage of Bidirectional GRU #30

Closed sharan21 closed 3 years ago

sharan21 commented 3 years ago

while declaring the encoder cell, the resultant hidden size is multiplied by hidden_factor. I think Pytorch already accommodates this new size and returns the outputs accordingly. Therefore there is no need to apply this scaling by hidden_factor.

sharan21 commented 3 years ago

Apologies, I am referring to a modified version of the code, so this issue is not relevant.