Closed embano1 closed 1 month ago
Seems something changed in Codecov requiring token:
Error: Codecov token not found. Please provide Codecov token with -t flag.
Will investigate
Oh, will investigate too. I had the same problem on topfew and figured it out. But wait, the actions report said everything passed?!?!
OK, you have to go in the settings for "Secrets and Variables" and set up a "repository secret", which I did. Is there a way to force the actions to re-run without pushing something?
Hm, seems that didn't fix it? Just reran your PR checks and still throws: https://github.com/timbray/quamina/actions/runs/9237494760/job/25465928548#step:8:32
Did you follow this procedure? https://docs.codecov.com/docs/adding-the-codecov-token
I will have a look, but first, how do you re-run the PR checks?
On May 27, 2024 at 8:59:09 AM, Michael Gasch @.***> wrote:
Hm, seems that didn't fix it? Just reran your PR checks and still throws: https://github.com/timbray/quamina/actions/runs/9237494760/job/25465928548#step:8:32
— Reply to this email directly, view it on GitHub https://github.com/timbray/quamina/issues/309#issuecomment-2133761305, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAEJE6E4CACDYX72G3LUNDZENJ43AVCNFSM6AAAAABIJRGFFGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMZTG43DCMZQGU . You are receiving this because you commented.Message ID: @.***>
See Re-run all Jobs
button
Oh, will investigate too. I had the same problem on topfew and figured it out. But wait, the actions report said everything passed?!?!
Guess the action is configured to not fail the workflow on error
Well, per the instructions at https://docs.codecov.com/docs/adding-the-codecov-token I added
env:
CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}
And that certainly changed things. It found the token, lots of failures saying token validation failed. I went and regenerated the token over at Codecov, updated the repository secret at GitHub. Not sure what to do next, will take a break and research some more.
Hmm, I notice that they're talking about codecov-action@4 in the docs page, our codecov point release is still 3.something. Worth bumping to @4?
~Yeah, let's try that!~
update: we're already on latest release: codecov/codecov-action@125fc84a9a348dbcf27191600683ec096ec9021c
Just noticed this note in the unit tests in PR #308: