search

timbray / quamina

Home of Quamina, a fast pattern-matching library in Go
Apache License 2.0
373 stars 18 forks source link

pat: remove limit of one * in shell style #320

Closed timbray closed 3 weeks ago

timbray commented 1 month ago

Note that this is a semantic change so will lead to release 1.1.0.

timbray commented 1 month ago

The CI is breaking because "package slices is not in GOROOT". I just introduced slices in a test so I could use slices.Contains. I could easily take slices out and write my own "contains" method in about 3 minutes but I'm reluctant to do that without understanding what's going on. Is the "slices" package magically weird? Hey @embano1, any ideas?

codecov-commenter commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 96.54%. Comparing base (e415ed3) to head (ee93bb5).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #320 +/- ## ========================================== + Coverage 96.10% 96.54% +0.44% ========================================== Files 18 18 Lines 1744 1735 -9 ========================================== - Hits 1676 1675 -1 + Misses 40 35 -5 + Partials 28 25 -3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

timbray commented 3 weeks ago

OK, fairly obvious that nobody wants to review PRs that dive deep into finite-automaton wrangling. Will merge. Next PR is about getting numeric matching right, which at least is user-visible.