search

timbray / quamina

Home of Quamina, a fast pattern-matching library in Go
Apache License 2.0
373 stars 18 forks source link

pat: correct numeric matching #329

Closed timbray closed 2 weeks ago

timbray commented 3 weeks ago

addresses #27

This is now consistent with current Ruler behavior except for the bug reported in https://github.com/aws/event-ruler/issues/163, which does not occur in Quamina.

timbray commented 3 weeks ago

Drat. Pulled in math/rand/v2, not realizing it's a go v1.22+ thing. I wish golangci-lint would catch this on my desktop. I guess the correct thing to do is roll back to math/rand which will cause CI complaints but those can be ignored. Fortunately Quamina doesn't need secure random numbers, they're just for test data.

codecov-commenter commented 3 weeks ago

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 93.93939% with 6 lines in your changes missing coverage. Please review.

Project coverage is 96.23%. Comparing base (b1c32f5) to head (49e80c7).

Files Patch % Lines
value_matcher.go 84.61% 5 Missing and 1 partial :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #329 +/- ## ========================================== - Coverage 96.48% 96.23% -0.26% ========================================== Files 18 18 Lines 1764 1804 +40 ========================================== + Hits 1702 1736 +34 - Misses 35 40 +5 - Partials 27 28 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

timbray commented 3 weeks ago

Hm, those benchmarks took me by surprise. Will need to study some more. Converting to draft PR.