Tools for reviewing pull requests

[stevage]

Following on from #308, the next thing that would be useful is tools to actually facilitate the review. Similar to how I review my own changes before making a commit, I'd really like to be able to open up a line-by-line diff of every changed file in the PR. I couldn't seem to find a way to achieve anything like that though - you can open up each commit, but generally when I look at a PR I don't care about the commits, I just want to look at the end result.

Perhaps the status page could detect that you're in PR-review mode and offer a couple more options?

Or maybe a tool "diff against branch" which shows a page listing all the changes, and then you can dive into each (with "o", "l" etc like with the status page).

[divmain]

Have you used the [f] diff against active command in the branch dashboard? This would show you the diff between the PR branch that you're evaluating and the master branch (or whatever you like). Or are you looking for something like the inline-diff, where changes are highlighted inline in the files themselves? If so, that's a very sizable task. Not impossible, but we'd have to establish some very clear UX and goals for the feature.

[stevage]

Ah, thanks - I never seem to be able to find that feature when I need it. diff against active isn't quite my ideal workflow, but it's pretty close to be honest. A couple of tweaks and it would be pretty perfect:

1) Replace some of the diff syntax with something more human friendly, eg:

--- a/README.md
+++ b/README.md
@@ -2,7 +2,7 @@

to:

README.md 

Line 2:

(and something similar like Line 44: when there are multiple diffs in one file)

2) Shortcut key to jump into an inline diff of the file that the cursor is currently inside.

[divmain]

The first change is unlikely to happen. However, I think we could add a shortcut key to jump to the inline-diff (or to the file itself).

[stoivo]

We can navigate in diff with go to symbol. This will take you to each file. Should we make it so you will go to each hunk with . and ,? maybe fold each hunk as well?

[stevage]

Not sure what you mean about "go to symbol". But yeah, something like d to jump to the inline diff, and o to open the whole file.

Not much need to navigate hunks imho, because it's already a diff view - there's not much between the hunks.

[stoivo]

Go to symbol is SUPER + r or CTRL + r, Can be use to go to function definitions.