search

timbru31 / PasswordProtect

🔐 PasswordProtect plugin for CraftBukkit/Spigot
https://dev.bukkit.org/projects/passwordprotect
MIT License
12 stars 6 forks source link

fix: Bugfix for nopassword permission, OpsRequirePassword and missing PasswordRequiredMessage #38

Closed dtmarius closed 4 years ago

dtmarius commented 4 years ago

actual state

  1. nopassword permission is only working if you are op
  2. OpsRequirePassword flag does not override nopassword permission
  3. PasswordRequiredMessage is not send to the player if the disableJailArea flag is set to true, because it is only send in the sendToJail(...) function.

target state

  1. nopassword permission should work without OP
  2. OpsRequirePassword flag should override nopassword permission (see your config.yml explaination at the bukkit site)

    # Are ops forced, to enter the password, too? opsRequirePassword: true

  3. If the Player need to login the Password required message should be sent to him.
timbru31 commented 4 years ago

Thanks! Can you give some more context which bugs this PR fixes?

dtmarius commented 4 years ago

Thanks! Can you give some more context which bugs this PR fixes?

I updated the pull request description.

timbru31 commented 4 years ago

I've did some major code overhaul, you are invited to test this build if you encounter and issues: https://ci.dustplanet.de/job/PasswordProtect/27/

One bug was fixed, too (banning did not work correctly anymore)