search

timbru31 / cordova-plugin-lottie-splashscreen

🐣 🎬 📱 Apache Cordova plugin to show Lottie animations as the splash screen with Airbnb's Lottie wrapper
https://www.npmjs.com/package/cordova-plugin-lottie-splashscreen
MIT License
128 stars 49 forks source link

Fix ios fullscreen #795

Open gultyayev opened 1 month ago

gultyayev commented 1 month ago

Fixes fullscreen animation

The main problem here, it seems, is that flexible margins were used on top of the container. This, in conjunction with flexibleWith & flexibleHeight, resulted in a non-fullscreen container which has a background. The AnimationView has the margins and they successfully center the animation within the fullscreen container, now).

Fixes ignored background color

Before, Light and Dark modes on iOS 12+ fell back to a hardcoded value instead of trying to fall back to the non-suffixed value, first. The PR fixes this by assigning an empty string. If no BackgroundColor is present, then the next check for .isEmpty will fire and a hardcoded fallback value will be used.

Removed orientation observer

Flexible margins seem to adjust the position of the animation automatically. So, we can remove the unneeded listener.

Closes #794

gultyayev commented 1 month ago

Check fails seem to be unrelated to my changes