timbunce / devel-nytprof

Devel::NYTProf is a powerful feature-rich source code profiler for Perl. (Mostly in maintenance mode, so PRs are much more likely to be acted upon than Issues.)
http://blog.timbunce.org/tag/nytprof/
67 stars 51 forks source link

[PATCH] nytprofhtml: CSS renders page unreadable for dark themes #104

Closed ghost closed 7 years ago

ghost commented 8 years ago

The CSS stylesheet nytprofhtml emits renders the HTML output unreadable on Desktops using a dark theme (a common mistake on the web - whenever you set a COLOR, you should make sure to set the BACKGROUND-COLOR as well...).

Here is a proposed patch:

--- devel-nytprof/bin/nytprofhtml   2016-10-02 12:32:18.172388995 +0200
+++ nytprofhtml 2016-10-02 12:50:30.049803322 +0200
@@ -1778,10 +1778,11 @@
  */

 /* Note: default values use the color-safe web palette. */
+a { color: blue; }
 a:visited { color: #6d00E6; }
 a:hover { color: red; }

-body { font-family: sans-serif; margin: 0px; }
+body { font-family: sans-serif; margin: 0px; background-color: #fff; color: #222; }
 .body_content { margin: 8px; }

 .header { font-family: sans-serif; padding-left: 0.5em; padding-right: 0.5em; }
ghost commented 8 years ago

See my pull request. Would be nice, if that could be merged. I have re-apply those patches whenever I switch branches or browse blindly :)

timbunce commented 7 years ago

PR merged. Thanks!