search

timbunce / devel-nytprof

Devel::NYTProf is a powerful feature-rich source code profiler for Perl. (Mostly in maintenance mode, so PRs are much more likely to be acted upon than Issues.)
http://blog.timbunce.org/tag/nytprof/
67 stars 51 forks source link

Issues discovered on Mac OS X #131

Open smpeters opened 5 years ago

smpeters commented 5 years ago

I was able to compile the most recent Github version and everything worked fine. That said, there were a few issues.

jkeenan commented 3 years ago

I was able to compile the most recent Github version and everything worked fine. That said, there were a few issues.

* `Makefile.PL` said `Warning: prerequisite JSON::MaybeXS 0 not found.` . If everything compiles and all the tests pass it is either not a real prerequisite or there is no test coverage for code where `JSON::MaybeXS` is required.

[snip]

NYTProf.xs:3999:20: warning: passing an object that undergoes default argument promotion to 'va_start' has undefined behavior
      [-Wvarargs]
    va_start(args, tag);
$ ack 'JSON::MaybeXS' bin lib t
bin/nytprofhtml
70:my $has_json = eval { require JSON::MaybeXS; JSON::MaybeXS->import(); 1 }
71:    or warn "Can't load JSON::MaybeXS module - HTML visualizations skipped ($@)\n";
873:        print $fh q{<br/>(Can't create visual treemap of subroutine exclusive times without the <a href="http://metacpan.org/release/JSON-MaybeXS/">JSON::MaybeXS</a> module.)<br/>};
jkeenan commented 1 year ago

I was able to compile the most recent Github version and everything worked fine. That said, there were a few issues.

* `Makefile.PL` said `Warning: prerequisite JSON::MaybeXS 0 not found.` . If everything compiles and all the tests pass it is either not a real prerequisite or there is no test coverage for code where `JSON::MaybeXS` is required.

Previously responded to.

* `NYTProf.xs:1220:1: warning: unused function 'get_str_id' [-Wunused-function]`

* several vararg warnings are displayed similar to
NYTProf.xs:3999:20: warning: passing an object that undergoes default argument promotion to 'va_start' has undefined behavior
      [-Wvarargs]
    va_start(args, tag);

I don't have access to Mac OS X. Can you tell me what C-compiler you were using and what version thereof? Thanks.