search

timbunce / devel-nytprof

Devel::NYTProf is a powerful feature-rich source code profiler for Perl. (Mostly in maintenance mode, so PRs are much more likely to be acted upon than Issues.)
http://blog.timbunce.org/tag/nytprof/
67 stars 51 forks source link

Test62 failures 20210324 #147

Closed jkeenan closed 3 years ago

jkeenan commented 3 years ago

This p.r. gets us part of the way toward a solution for https://github.com/timbunce/devel-nytprof/issues/143, but there are still 16 unit test failures in t/test62-subcaller1-b.t.

jkeenan commented 3 years ago

@timbunce, I have removed the 'Draft' status from this pull request and it is ready for your review. The Devel-NYTProf test suite once again passes on Perl 5 blead (see https://travis-ci.org/github/jkeenan/devel-nytprof).

This p.r. consists of 11 separate commits. Of these, the following 4 are essential to the correction of the problem: https://github.com/timbunce/devel-nytprof/pull/147/commits/87c646997a6c3b05dfcd7dfe781f6ea11addeb98 https://github.com/timbunce/devel-nytprof/pull/147/commits/9700e19a7c4c5fad494ccb5e7b8af38d7c670689 https://github.com/timbunce/devel-nytprof/pull/147/commits/466efcd026232a46cac0b88e90a85192e2804273 https://github.com/timbunce/devel-nytprof/pull/147/commits/d18e466efa8a1a51995ed06dbc2d42468307aacd They could presumably be squashed before merging into master. Let's discuss.

The other 7 commits are more of a housekeeping nature. I think the changes made to Makefile.PL, MANIFEST, MANIFEST.SKIP and .gitignore are generally valid and can be merged. The changes to .travis.yml and .appveyor.yml (renamed from your appveyor.yml) were done to facilitate my own testing and debugging and should probably not go into master. Again, let's discuss.

Thank you very much. Jim Keenan