search

timbunce / devel-nytprof

Devel::NYTProf is a powerful feature-rich source code profiler for Perl. (Mostly in maintenance mode, so PRs are much more likely to be acted upon than Issues.)
http://blog.timbunce.org/tag/nytprof/
67 stars 51 forks source link

Selective cperl core cherries 20210408 #156

Closed jkeenan closed 3 years ago

jkeenan commented 3 years ago

The purpose of this pull request is to pick some low-hanging fruit from a larger p.r. submitted in 2019 by @rurban.

3 of the commits are straightforward cherry-picks; 2 required slight corrections or adaptations.

I hope to work through the balance of the 44 commits and incorporate them into thematically grouped pull requests.

Thank you very much. Jim Keenan

jkeenan commented 3 years ago

Clearly okay, but all things considered; is there a benefit to adding the ./? Really just asking for my own information.

I tried it with a single ./. The test failed. Reini had it right.

rurban commented 3 years ago

Clearly okay, but all things considered; is there a benefit to adding the ./? Really just asking for my own information.

I tried it with a single ./. The test failed. Reini had it right.

Which './'? I normally added ./ to skip @INC searches, which are still security relevant in older perls. But I didn't see any ./ in these commits