search

timbunce / devel-nytprof

Devel::NYTProf is a powerful feature-rich source code profiler for Perl. (Mostly in maintenance mode, so PRs are much more likely to be acted upon than Issues.)
http://blog.timbunce.org/tag/nytprof/
67 stars 50 forks source link

Makefile.PL: remove or replace targets using 'svn' #177

Closed jkeenan closed 9 months ago

jkeenan commented 3 years ago

In Makefile.PL there are 3 targets which assume that we're still using Subversion for version control.

svnmanifest::
    svn list -R .@HEAD | sort | grep -v '/$$' > MANIFEST
    svn diff MANIFEST
checkkeywords:
    $(RM_RF) blib
    find .  \( -name .svn -prune -or -name t -prune -or -name \*.pm -or -name \*.PL -or -name \*.pl \) -type f \
        -exec bash -c '[ "$$(svn pg svn:keywords {})" != "Id Revision Date" ] && echo svn propset svn:keywords \"Id Revision Date\" {}' \;
checkpod:
    $(RM_RF) blib
    find . -type f \( -name .svn -prune -o -name \*.pm -o -name \*.PL -o -name \*.pl \) \
        -exec podchecker {} \; 2>&1 | grep -v "pod syntax OK"

These 3 targets should be replaced with equivalent commands using git or -- perhaps, better still, removed altogether.

Being focused on other things at the moment, this is a task that a newcomer could pick up.

Thank you very much. Jim Keenan

jkeenan commented 9 months ago

The objectives of this ticket were satisfied with this commit:

$ gitshowf fc3ef58bda7dd
commit fc3ef58bda7dd4f29ca2e300aae11db9197f1e31
Merge: 5c915c9 66a6a34
Author:     James E Keenan <jkeenan@cpan.org>
AuthorDate: Fri Oct 15 09:05:30 2021 -0400
Commit:     James E Keenan <jkeenan@cpan.org>
CommitDate: Fri Oct 15 09:05:30 2021 -0400

    Merge branch 'no-svn-20210926'

    For: https://github.com/timbunce/devel-nytprof/pull/196

Closing this issue.