search

timbunce / devel-nytprof

Devel::NYTProf is a powerful feature-rich source code profiler for Perl. (Mostly in maintenance mode, so PRs are much more likely to be acted upon than Issues.)
http://blog.timbunce.org/tag/nytprof/
67 stars 50 forks source link

Skip 4 test files on quadmath (Linux) builds #187

Closed jkeenan closed 3 years ago

jkeenan commented 3 years ago

Originally reported by H Merijn Brand; cd. https://github.com/timbunce/devel-nytprof/issues/168#issuecomment-832696861

@Tux, can you try this out?

Thank you very much. Jim Keenan

Tux commented 3 years ago 
All tests successful.
Files=55, Tests=4793, 101 wallclock secs ( 0.84 usr  0.11 sys + 40.19 cusr  8.05 csys = 49.19 CPU)
Result: PASS

I've been digging in the code and git history, but I could find no instructions on how to generate t/nytprof_11-reader.out.txt. This patch just skis the tests, but it would be swell if the suite could pick the correct/matching profile from a set of profiles. This is wiping the problem under the carpet. Good for now, but room for improvement :)

jkeenan commented 3 years ago

On 5/5/21 10:46 AM, H.Merijn Brand wrote:

|All tests successful. Files=55, Tests=4793, 101 wallclock secs ( 0.84 usr 0.11 sys + 40.19 cusr 8.05 csys = 49.19 CPU) Result: PASS |

I've been digging in the code and git history, but I could find no instructions on how to /generate/ |t/nytprof_11-reader.out.txt|. This patch just skips the tests, but it would be swell if the suite could pick the correct/matching profile from a set of profiles. This is wiping the problem under the carpet. Good for now, but room for improvement :)

Yes, this is one of the challenges we face in testing Devel-NYTProf.

Note that in the docs there is mention of a mailing list for NYTProf on Google Groups: https://groups.google.com/g/develnytprof-dev

In the coming month, I hope to do a post on there on all the dilemmas we face in testing of NYTprof.

Thank you very much. Jim Keenan

jkeenan commented 3 years ago

I'm replacing this p.r. with https://github.com/timbunce/devel-nytprof/pull/189. Thanks.