search

timbunce / devel-nytprof

Devel::NYTProf is a powerful feature-rich source code profiler for Perl. (Mostly in maintenance mode, so PRs are much more likely to be acted upon than Issues.)
http://blog.timbunce.org/tag/nytprof/
67 stars 50 forks source link

Gh 192 no tablesorter #193

Closed jkeenan closed 2 years ago

jkeenan commented 2 years ago

This pull request should be considered a first-draft of a response to https://github.com/timbunce/devel-nytprof/issues/192 filed by @shawnlaffan. In this branch we drop jquery.tablesorter.min.js entirely.

This gives me good results on Linux in Firefox, Chromium, Chrome and Opera. However, it needs to be tested in real-life situations on Windows and other OSes as well. We will also have to examine the history of this jquery file within this library, so that we know what we might be losing if we drop it.

Please review.

timbunce commented 2 years ago

I'm puzzled. Does this remove the ability to sort tables at all? That seems like a drastic response to the problem at hand. Removing floatThead, reverting to an early state, seems like a better approach.

p.s. I recommend not updating VERSION till you're ready to release. Or, alternately, update it in a separate PR. Either way will avoid problems if, for example, you wanted to revert a PR, or the PR doesn't get merged into the release it was intended to.

jkeenan commented 2 years ago

I'm puzzled. Does this remove the ability to sort tables at all? That seems like a drastic response to the problem at hand. Removing floatThead, reverting to an early state, seems like a better approach.

p.s. I recommend not updating VERSION till you're ready to release. Or, alternately, update it in a separate PR. Either way will avoid problems if, for example, you wanted to revert a PR, or the PR doesn't get merged into the release it was intended to.

Pausing this p.r. in favor of https://github.com/timbunce/devel-nytprof/pull/194.

jkeenan commented 2 years ago

https://github.com/timbunce/devel-nytprof/pull/194 has been merged into master, so this p.r. is now superseded and closable.