timbunce / devel-nytprof

Devel::NYTProf is a powerful feature-rich source code profiler for Perl. (Mostly in maintenance mode, so PRs are much more likely to be acted upon than Issues.)
http://blog.timbunce.org/tag/nytprof/
67 stars 51 forks source link

Skip test that fails on Windows/msys #199

Open pauloscustodio opened 2 years ago

jkeenan commented 2 years ago

My feeling is that this pull request should be rejected because it is not needed. We added continuous integration code for travis-ci.com several years ago, but my impression is that that service is no longer supported. Besides that, even when travis was viable we were only running it on Linux -- never on Windows. (We've used AppVeyor for CI on Windows and I got a PASS on it just 11 days ago.) The only thing clearly demonstrated by your failure report is that github is no longer connecting with travis-ci -- which does not constitute a failure in this Perl distribution.

pauloscustodio commented 2 years ago

Without the patch I submitted, the test fails on Windows/msys2:

$ cpan Devel::NYTProf [...] Fetching with HTTP::Tiny: https://cpan.org/authors/id/J/JK/JKEENAN/Devel-NYTProf-6.11.tar.gz [...] t/50-errno.t ............. 1/8 Failed test '$! should not be altered by NYTProf i/o' at t/50-errno.t line 58. got: '0' expected: '3' Looks like you failed 1 test of 8.

$ uname -a MSYS_NT-10.0-19043 DESKTOP-AERD817 3.3.5-341.x86_64 2022-05-30 21:10 UTC x86_64 Msys

$ perl -v

This is perl 5, version 32, subversion 1 (v5.32.1) built for x86_64-msys-thread-multi

jkeenan commented 1 year ago

Without the patch I submitted, the test fails on Windows/msys2:

$ cpan Devel::NYTProf [...] Fetching with HTTP::Tiny: https://cpan.org/authors/id/J/JK/JKEENAN/Devel-NYTProf-6.11.tar.gz [...] t/50-errno.t ............. 1/8 Failed test '$! should not be altered by NYTProf i/o' at t/50-errno.t line 58. got: '0' expected: '3' Looks like you failed 1 test of 8.

$ uname -a MSYS_NT-10.0-19043 DESKTOP-AERD817 3.3.5-341.x86_64 2022-05-30 21:10 UTC x86_64 Msys

$ perl -v

This is perl 5, version 32, subversion 1 (v5.32.1) built for x86_64-msys-thread-multi

I have no access to msys. Do you have any insight as to why this test is failing?

Is it still failing if you build Devel-NYTProf with perl-5.38?